[JENKINS-52165] Do not enable watch mode automatically in tests #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Jan 23, 2019
| @@ -463,114 +464,10 @@ private Object writeReplace() { | |||
| } | |||
| } | |||
|
|
|||
| @Ignore("TODO too flaky to run in CI") | |||
| @Issue("JENKINS-38381") | |||
| @Test public void remoteVoluminousLogger() throws Exception { | |||
There was a problem hiding this comment.
Turned out to be too hard to make this be meaningful in a functional test; giving up on it for now.
dwnusbaum
approved these changes
Jan 23, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides the original discussion in #84 (comment), I found that watch mode was being activated in JFR “serverless” builds, including Jenkins X in
--prowmode, due to this questionable behavior. Probably less surprising to enable watch mode only when tests explicitly ask for it.I considered making some of these test suites
Parameterizedbut they were already pretty long-running and it looked complicated: some tests only make sense in watch mode or vice-versa, so was not sure whether this would be desirable.