Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix label in step generator #121

Merged
merged 3 commits into from
Aug 14, 2020
Merged

fix label in step generator #121

merged 3 commits into from
Aug 14, 2020

Conversation

jetersen
Copy link
Member

@jetersen jetersen commented Oct 7, 2019

when using the generator it would return powershell label: '', script: 'test'

@dwnusbaum dwnusbaum requested a review from car-roll December 6, 2019 15:55
dwnusbaum
dwnusbaum requested changes Dec 6, 2019
View reviewed changes
Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Casz Actually, it looks like this makes ShellStepTest configRoundTrip fail. I didn't check to see if that's an actual problem or if the test just needs to be updated.

@jetersen
Copy link
Member Author

jetersen commented Dec 6, 2019

Believe test needs to be updated I just never got around to this PR again, thanks for the reminder.

This was referenced Aug 14, 2020
Merged
Merged
@dwnusbaum dwnusbaum merged commit 75c3f9b into jenkinsci:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwnusbaum dwnusbaum dwnusbaum approved these changes

@car-roll car-roll Awaiting requested review from car-roll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jetersen @dwnusbaum