Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selenium server standalone and htmlunitdriver should not be bundled with plugin #65

Open
rouke-broersma opened this issue Apr 21, 2016 · 3 comments

Comments

@rouke-broersma
Copy link
Member

Determine if there is another way to distribute the selenium server standalone and htmlunitdriver jars. This would be ideal, but current setup is acceptable.

@yoav-miles-sp
Copy link

I think the best way to handle both selenium server standalone and htmlunitdriver jars is to take them out of the plugin and check for a new jar once in a while (say 1 month). Once a new jar is available we get to keep the old jar and start working with the new one (once all nodes are idle). If there are older jars they can be discarded.
This way the plugin doesn't have to keep up with the selenium server development cycle - we're already at 3.5.3...

Thank you very much!

@rouke-broersma
Copy link
Member Author

rouke-broersma commented Sep 3, 2017

This sounds good in theory but actually requires large parts of the plugin to be re-written as the plugin and selenium-server are very much interwoven at the moment. I currently do not use selenium and have started a full-time job so I don't really have much interest in starting this undertaking.

Using an external jar would not be hard at all as we already have scripts for that in the project itself, and Jenkins has a build in way of downloading external dependencies for plugins as well. This is used by the chrome webdriver plugin for example. We just cannot use that way right now because of the way the plugin is put together, and I do not have the time or interest for it right now.

@yoav-miles-sp
Copy link

Thanks for the reply! I hope I can get some time in the future to work on it. May you never have to deal with selenium again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants