Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up current SpotBugs releases, kill @Nullable #1063

Open
jglick opened this issue Dec 6, 2024 · 0 comments
Open

Pick up current SpotBugs releases, kill @Nullable #1063

jglick opened this issue Dec 6, 2024 · 0 comments

Comments

@jglick
Copy link
Member

jglick commented Dec 6, 2024

spotbugs/spotbugs#2795 (spotbugs/spotbugs#2793) for example would be useful to pick up for things like jenkinsci/jenkins#9921.

IIUC #1049 and similar are held up because of #963 (comment). Not sure if there is any particular validation that has been performed in the past for Spotbugs updates to check for massive increases in warnings, like a selected list of complex plugins to test with this property override.

I tried it on a proprietary plugin and noticed that @Nullable will need to be removed from User.getById. Same for Computer.getChannel, and an API in a proprietary plugin. Basically we need to remove every occurrence of @Nullable everywhere and deliberately leave these methods unannotated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant