Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JaCoCo hook no longer runs #490

Closed
jtnord opened this issue Mar 17, 2023 · 1 comment · Fixed by #491
Closed

JaCoCo hook no longer runs #490

jtnord opened this issue Mar 17, 2023 · 1 comment · Fixed by #491
Labels

Comments

@jtnord
Copy link
Member

jtnord commented Mar 17, 2023

Jenkins and plugins versions report

Environment

Plugin hooks are not run as the code is checking incorrect data (pom) that is not fully populated.


The maven model is a minimal representation of the actual pom and is both brittle and incomplete.

As mentioned in #486 (comment)

What Operating System are you using (both controller, and any agents involved in the problem)?

N/A

Reproduction steps

create a war with containing jacoco

run the PCT Tests

Expected Results

all jacoco tests pass (and the jacoco hook is run correctly)

Actual Results

the tests fail as the jacoco hook is not excersized and does not add jacoco:prepare-agent to the mvn arguments when adding tests.

ExecutionFileLoaderTest.testLoadBundleWithExecFile and a few others require a jacoco file which is provided when running the tests.

Anything else?

possibly affects all other plugins as well that are not using incrementals (that would inline the parent groupId) as well as potential plugins that are but are to be tested locally

@jtnord jtnord added the bug label Mar 17, 2023
@basil basil changed the title so,e plugin hooks are not correctly run JaCoCo hook no longer run Mar 17, 2023
@basil
Copy link
Member

basil commented Mar 17, 2023

This was actually fixed in jenkinsci/jacoco-plugin#206 but in the meantime I will work around the regression by removing the check for groupId. That should get the hook to pass against https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/jacoco/3.3.2/jacoco-3.3.2.pom.

@basil basil changed the title JaCoCo hook no longer run JaCoCo hook no longer runs Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants