From 03787adc0fad43a8a03f45d1dd8c606046324714 Mon Sep 17 00:00:00 2001 From: Markus Winter Date: Wed, 21 Aug 2024 20:19:55 +0200 Subject: [PATCH 1/3] [JENKINS-73668] fix stlying of rowSelectionController dropdown ensure there is enough gap between entries --- war/src/main/scss/components/_row-selection-controller.scss | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/war/src/main/scss/components/_row-selection-controller.scss b/war/src/main/scss/components/_row-selection-controller.scss index df5cf1553175..ca15b95965ad 100644 --- a/war/src/main/scss/components/_row-selection-controller.scss +++ b/war/src/main/scss/components/_row-selection-controller.scss @@ -1,6 +1,8 @@ .jenkins-table__checkbox-container { position: relative; display: flex; + align-items: center; + gap: 0.2rem; } .jenkins-table__checkbox { @@ -142,9 +144,10 @@ left: 1.375rem; display: flex; flex-direction: column; + gap: 1rem; border-radius: 0.8rem; z-index: 999; - padding: 0.4rem; + padding: 0.4rem 0.4rem 1rem; box-shadow: inset 0 0 0 2px rgba(white, 0.05), 0 0 0 1px rgba(black, 0.05), From 49b96571ef0f17fb5b820d928ba7f1928843f6d0 Mon Sep 17 00:00:00 2001 From: Markus Winter Date: Wed, 21 Aug 2024 22:35:34 +0200 Subject: [PATCH 2/3] style it as before with smaller dropdown button --- .../components/_row-selection-controller.scss | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/war/src/main/scss/components/_row-selection-controller.scss b/war/src/main/scss/components/_row-selection-controller.scss index ca15b95965ad..b4c5b563a467 100644 --- a/war/src/main/scss/components/_row-selection-controller.scss +++ b/war/src/main/scss/components/_row-selection-controller.scss @@ -1,8 +1,6 @@ .jenkins-table__checkbox-container { position: relative; display: flex; - align-items: center; - gap: 0.2rem; } .jenkins-table__checkbox { @@ -95,14 +93,14 @@ .jenkins-table__checkbox-options { height: 1.375rem; - min-height: unset; - padding: 0 0.2rem; - margin-left: 0.2rem; + min-height: unset !important; + padding: 0 0.2rem !important; + margin: 0 0 0 0.2rem !important; border-radius: 6px; svg { - width: 0.9rem; - height: 0.9rem; + max-width: 0.9rem; + max-height: 0.9rem; pointer-events: none; color: var(--input-border); transition: var(--standard-transition); @@ -144,10 +142,9 @@ left: 1.375rem; display: flex; flex-direction: column; - gap: 1rem; border-radius: 0.8rem; z-index: 999; - padding: 0.4rem 0.4rem 1rem; + padding: 0.4rem; box-shadow: inset 0 0 0 2px rgba(white, 0.05), 0 0 0 1px rgba(black, 0.05), @@ -188,6 +185,9 @@ justify-content: flex-start; gap: 0.75rem; border-radius: 10px; + margin: 0 !important; + padding: .5rem .9rem !important; + min-height: 2.25rem !important } &--visible { From 05171baa7b08c1aaeba69f08e6f740556ad13579 Mon Sep 17 00:00:00 2001 From: Markus Winter Date: Wed, 21 Aug 2024 23:24:35 +0200 Subject: [PATCH 3/3] apply prettier --- war/src/main/scss/components/_row-selection-controller.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/war/src/main/scss/components/_row-selection-controller.scss b/war/src/main/scss/components/_row-selection-controller.scss index b4c5b563a467..e373cd4bf721 100644 --- a/war/src/main/scss/components/_row-selection-controller.scss +++ b/war/src/main/scss/components/_row-selection-controller.scss @@ -186,8 +186,8 @@ gap: 0.75rem; border-radius: 10px; margin: 0 !important; - padding: .5rem .9rem !important; - min-height: 2.25rem !important + padding: 0.5rem 0.9rem !important; + min-height: 2.25rem !important; } &--visible {