From a487d653df29fd2754e3b5450a1d268ad96ae4c0 Mon Sep 17 00:00:00 2001
From: strangelookingnerd
 <49242855+strangelookingnerd@users.noreply.github.com>
Date: Tue, 26 Nov 2024 13:22:15 +0100
Subject: [PATCH] Handle icon and status of a job in jelly views

---
 .../resources/hudson/model/Job/index.jelly    | 32 ++++++++++++++++---
 .../hudson/views/IconColumn/column.jelly      | 20 ++++++++++--
 .../hudson/views/StatusColumn/column.jelly    | 26 +++++++--------
 .../resources/lib/hudson/projectView.jelly    |  4 +--
 .../main/resources/images/symbols/empty.svg   |  1 +
 5 files changed, 61 insertions(+), 22 deletions(-)
 create mode 100644 war/src/main/resources/images/symbols/empty.svg

diff --git a/core/src/main/resources/hudson/model/Job/index.jelly b/core/src/main/resources/hudson/model/Job/index.jelly
index d9b214900c7bb..d879c0ca5d216 100644
--- a/core/src/main/resources/hudson/model/Job/index.jelly
+++ b/core/src/main/resources/hudson/model/Job/index.jelly
@@ -31,11 +31,33 @@ THE SOFTWARE.
       <div class="jenkins-app-bar">
         <div class="jenkins-app-bar__content jenkins-build-caption">
           <j:set var="lastBuild" value="${it.lastBuild}" />
-          <j:if test="${lastBuild != null}">
-            <a href="${rootURL + '/' + lastBuild.url}" class="jenkins-!-display-contents" tabindex="-1">
-              <l:icon src="symbol-status-${lastBuild.iconColor.iconName}" tooltip="${lastBuild.iconColor.description}"/>
-            </a>
-          </j:if>
+          <j:choose>
+            <j:when test="${lastBuild != null}">
+              <a href="${rootURL + '/' + lastBuild.url}" class="jenkins-!-display-contents" tabindex="-1">
+                <l:icon src="symbol-status-${lastBuild.iconColor.iconName}" tooltip="${lastBuild.iconColor.description}"/>
+              </a>
+            </j:when>
+            <j:otherwise>
+              <j:choose>
+                <j:when test="${it.icon != null}">
+                  <j:choose>
+                    <j:when test="${it.icon.iconClassName != null}">
+                      <!-- symbols and icons -->
+                      <l:icon src="${it.icon.iconClassName}" tooltip="${it.descriptor.displayName}" />
+                    </j:when>
+                    <j:otherwise>
+                      <!-- images -->
+                      <l:icon src="${it.icon.getImageOf(null)}" tooltip="${it.descriptor.displayName}" />
+                    </j:otherwise>
+                  </j:choose>
+                </j:when>
+                <j:otherwise>
+                  <!-- defaults to the item type icon -->
+                  <l:icon src="${it.descriptor.iconClassName}" tooltip="${it.descriptor.displayName}" />
+                </j:otherwise>
+              </j:choose>
+            </j:otherwise>
+          </j:choose>
           <h1 class="job-index-headline page-headline">
             <l:breakable value="${it.displayName}"/>
           </h1>
diff --git a/core/src/main/resources/hudson/views/IconColumn/column.jelly b/core/src/main/resources/hudson/views/IconColumn/column.jelly
index 64d859d3c19b1..f3255d2bc4384 100644
--- a/core/src/main/resources/hudson/views/IconColumn/column.jelly
+++ b/core/src/main/resources/hudson/views/IconColumn/column.jelly
@@ -26,8 +26,24 @@ THE SOFTWARE.
 <j:jelly xmlns:j="jelly:core" xmlns:l="/lib/layout">
   <td class="jenkins-table__cell--tight jenkins-table__icon">
     <div class="jenkins-table__cell__button-wrapper">
-      <!-- defaults to the item type icon -->
-      <l:icon src="${job.descriptor.iconClassName}" tooltip="${job.descriptor.displayName}" />
+      <j:choose>
+        <j:when test="${job.icon != null}">
+          <j:choose>
+            <j:when test="${job.icon.iconClassName != null}">
+              <!-- symbols and icons -->
+              <l:icon src="${job.icon.iconClassName}" tooltip="${job.descriptor.displayName}" />
+            </j:when>
+            <j:otherwise>
+              <!-- images -->
+              <l:icon src="${job.icon.getImageOf(null)}" tooltip="${job.descriptor.displayName}" />
+            </j:otherwise>
+          </j:choose>
+        </j:when>
+        <j:otherwise>
+          <!-- defaults to the item type icon -->
+          <l:icon src="${job.descriptor.iconClassName}" tooltip="${job.descriptor.displayName}" />
+        </j:otherwise>
+      </j:choose>
     </div>
   </td>
 </j:jelly>
\ No newline at end of file
diff --git a/core/src/main/resources/hudson/views/StatusColumn/column.jelly b/core/src/main/resources/hudson/views/StatusColumn/column.jelly
index 428a173fedf6b..d914ca54d286a 100644
--- a/core/src/main/resources/hudson/views/StatusColumn/column.jelly
+++ b/core/src/main/resources/hudson/views/StatusColumn/column.jelly
@@ -23,18 +23,18 @@ THE SOFTWARE.
 -->
 
 <?jelly escape-by-default='true'?>
-<j:jelly xmlns:j="jelly:core" xmlns:l="/lib/layout" xmlns:t="/lib/hudson">
-  <j:choose>
-    <j:when test="${job.iconColor.iconName != null}">
-      <td class="jenkins-table__cell--tight jenkins-table__icon" data="${job.iconColor.ordinal()}">
-        <div class="jenkins-table__cell__button-wrapper">
+<j:jelly xmlns:j="jelly:core" xmlns:l="/lib/layout">
+  <td class="jenkins-table__cell--tight jenkins-table__icon" data="${job.iconColor.ordinal()}">
+    <div class="jenkins-table__cell__button-wrapper">
+      <j:choose>
+        <j:when test="${job.iconColor.iconName != null}">
           <l:icon src="symbol-status-${job.iconColor.iconName}" tooltip="${job.iconColor.description}" />
-        </div>
-      </td>
-    </j:when>
-    <j:otherwise>
-      <!-- This is for special conditions, such as folders -->
-      <t:ballColorTd it="${job.iconColor}" />
-    </j:otherwise>
-  </j:choose>
+        </j:when>
+        <j:otherwise>
+          <!-- empty icon -->
+          <l:icon src="symbol-empty" />
+        </j:otherwise>
+      </j:choose>
+    </div>
+  </td>
 </j:jelly>
diff --git a/core/src/main/resources/lib/hudson/projectView.jelly b/core/src/main/resources/lib/hudson/projectView.jelly
index 75842abc1e9f6..8a37ea62d0998 100644
--- a/core/src/main/resources/lib/hudson/projectView.jelly
+++ b/core/src/main/resources/lib/hudson/projectView.jelly
@@ -102,8 +102,8 @@ THE SOFTWARE.
                     <l:icon src="symbol-status-${job.iconColor.iconName}" tooltip="${job.iconColor.description}" />
                   </j:when>
                   <j:otherwise>
-                    <!-- This is for special conditions, such as folders -->
-                    <l:icon src="${job.iconColor.iconClassName}" />
+                    <!-- empty icon -->
+                    <l:icon src="symbol-empty" />
                   </j:otherwise>
                 </j:choose>
               </div>
diff --git a/war/src/main/resources/images/symbols/empty.svg b/war/src/main/resources/images/symbols/empty.svg
new file mode 100644
index 0000000000000..08353db9925bb
--- /dev/null
+++ b/war/src/main/resources/images/symbols/empty.svg
@@ -0,0 +1 @@
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512"><title>Empty</title></svg>
\ No newline at end of file