From 8a6336016edf5cfa9b7f53c034c032f0bdb979d8 Mon Sep 17 00:00:00 2001 From: Kris Stern Date: Wed, 10 Apr 2024 01:25:43 +0800 Subject: [PATCH] apply suggestions from code review --- core/src/main/java/hudson/model/Job.java | 18 ++++++++++++++++-- .../hudson/model/TopLevelItemDescriptor.java | 4 ++-- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/core/src/main/java/hudson/model/Job.java b/core/src/main/java/hudson/model/Job.java index 1a10bc9003646..548aced2f0f8c 100644 --- a/core/src/main/java/hudson/model/Job.java +++ b/core/src/main/java/hudson/model/Job.java @@ -53,7 +53,19 @@ import hudson.search.SearchItems; import hudson.security.ACL; import hudson.tasks.LogRotator; -import hudson.util.*; +import hudson.util.AlternativeUiTextProvider; +import hudson.util.ChartUtil; +import hudson.util.ColorPalette; +import hudson.util.CopyOnWriteList; +import hudson.util.DataSetBuilder; +import hudson.util.DescribableList; +import hudson.util.FormApply; +import hudson.util.Graph; +import hudson.util.ProcessTree; +import hudson.util.RunList; +import hudson.util.ShiftedCategoryAxis; +import hudson.util.StackedAreaRenderer2; +import hudson.util.TextFile; import hudson.widgets.HistoryWidget; import hudson.widgets.HistoryWidget.Adapter; import hudson.widgets.Widget; @@ -108,7 +120,9 @@ import org.kohsuke.accmod.restrictions.NoExternalUse; import org.kohsuke.args4j.Argument; import org.kohsuke.args4j.CmdLineException; -import org.kohsuke.stapler.*; +import org.kohsuke.stapler.StaplerOverridable; +import org.kohsuke.stapler.StaplerRequest; +import org.kohsuke.stapler.StaplerResponse; import org.kohsuke.stapler.export.Exported; import org.kohsuke.stapler.interceptor.RequirePOST; import org.kohsuke.stapler.verb.POST; diff --git a/core/src/main/java/hudson/model/TopLevelItemDescriptor.java b/core/src/main/java/hudson/model/TopLevelItemDescriptor.java index 8afd739f68c93..73db6a3acbbf5 100644 --- a/core/src/main/java/hudson/model/TopLevelItemDescriptor.java +++ b/core/src/main/java/hudson/model/TopLevelItemDescriptor.java @@ -287,7 +287,7 @@ public static ExtensionList all() { } @Restricted(NoExternalUse.class) - public static FormValidation doCheckDisplayNameOrNull(@AncestorInPath AbstractProject project, @QueryParameter String value) { - return Jenkins.get().doCheckDisplayName(value, project.getName()); + public FormValidation doCheckDisplayNameOrNull(@AncestorInPath TopLevelItem item, @QueryParameter String value) { + return Jenkins.get().doCheckDisplayName(value, item.getName()); } }