diff --git a/bom/pom.xml b/bom/pom.xml
index 5a295c6a80c8..4ad351bf60b2 100644
--- a/bom/pom.xml
+++ b/bom/pom.xml
@@ -56,7 +56,7 @@ THE SOFTWARE.
org.springframework
spring-framework-bom
- 5.3.33
+ 5.3.34
pom
import
diff --git a/core/src/main/java/hudson/ExtensionFinder.java b/core/src/main/java/hudson/ExtensionFinder.java
index 801735835c0f..7301bcc39988 100644
--- a/core/src/main/java/hudson/ExtensionFinder.java
+++ b/core/src/main/java/hudson/ExtensionFinder.java
@@ -298,9 +298,11 @@ protected Injector resolve() {
}
private void refreshExtensionAnnotations() {
+ LOGGER.finer(() -> "refreshExtensionAnnotations()");
for (ExtensionComponent ec : moduleFinder.find(GuiceExtensionAnnotation.class, Hudson.getInstance())) {
GuiceExtensionAnnotation gea = ec.getInstance();
extensionAnnotations.put(gea.annotationType, gea);
+ LOGGER.finer(() -> "found " + gea.getClass());
}
}
@@ -328,6 +330,7 @@ public Injector getContainer() {
*/
@Override
public synchronized ExtensionComponentSet refresh() throws ExtensionRefreshException {
+ LOGGER.finer(() -> "refresh()");
refreshExtensionAnnotations();
// figure out newly discovered sezpoz components
List> delta = new ArrayList<>();
diff --git a/core/src/main/java/hudson/slaves/JNLPLauncher.java b/core/src/main/java/hudson/slaves/JNLPLauncher.java
index 9add9faf0c3f..4f0cbc1e6153 100644
--- a/core/src/main/java/hudson/slaves/JNLPLauncher.java
+++ b/core/src/main/java/hudson/slaves/JNLPLauncher.java
@@ -175,7 +175,7 @@ public String getTunnel() {
*/
@DataBoundSetter
public void setTunnel(String tunnel) {
- this.tunnel = tunnel;
+ this.tunnel = Util.fixEmptyAndTrim(tunnel);
}
@Override
diff --git a/core/src/main/java/jenkins/model/Jenkins.java b/core/src/main/java/jenkins/model/Jenkins.java
index 77e6f69ec875..b08ac6c8941d 100644
--- a/core/src/main/java/jenkins/model/Jenkins.java
+++ b/core/src/main/java/jenkins/model/Jenkins.java
@@ -2897,13 +2897,16 @@ public ExtensionList getExtensionList(String extensionType) throws ClassNotFound
*/
public void refreshExtensions() throws ExtensionRefreshException {
ExtensionList finders = getExtensionList(ExtensionFinder.class);
+ LOGGER.finer(() -> "refreshExtensions " + finders);
for (ExtensionFinder ef : finders) {
if (!ef.isRefreshable())
throw new ExtensionRefreshException(ef + " doesn't support refresh");
}
List fragments = new ArrayList<>();
+
for (ExtensionFinder ef : finders) {
+ LOGGER.finer(() -> "searching " + ef);
fragments.add(ef.refresh());
}
ExtensionComponentSet delta = ExtensionComponentSet.union(fragments).filtered();
@@ -2912,12 +2915,21 @@ public void refreshExtensions() throws ExtensionRefreshException {
List> newFinders = new ArrayList<>(delta.find(ExtensionFinder.class));
while (!newFinders.isEmpty()) {
ExtensionFinder f = newFinders.remove(newFinders.size() - 1).getInstance();
+ LOGGER.finer(() -> "found new ExtensionFinder " + f);
ExtensionComponentSet ecs = ExtensionComponentSet.allOf(f).filtered();
newFinders.addAll(ecs.find(ExtensionFinder.class));
delta = ExtensionComponentSet.union(delta, ecs);
}
+ // we may not have found a new Extension finder but we may be using an extension finder that is extensible
+ // e.g. hudson.ExtensionFinder.GuiceFinder is extensible by GuiceExtensionAnnotation which is done by the variant plugin
+ // so lets give it one more chance.
+ for (ExtensionFinder ef : finders) {
+ LOGGER.finer(() -> "searching again in " + ef);
+ delta = ExtensionComponentSet.union(delta, ef.refresh().filtered());
+ }
+
for (ExtensionList el : extensionLists.values()) {
el.refresh(delta);
}
diff --git a/test/src/test/java/hudson/slaves/JNLPLauncherTest.java b/test/src/test/java/hudson/slaves/JNLPLauncherTest.java
index e71b2fbcce9c..330d241c4a68 100644
--- a/test/src/test/java/hudson/slaves/JNLPLauncherTest.java
+++ b/test/src/test/java/hudson/slaves/JNLPLauncherTest.java
@@ -27,6 +27,7 @@
import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.instanceOf;
import static org.hamcrest.Matchers.is;
+import static org.hamcrest.Matchers.nullValue;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
@@ -112,6 +113,31 @@ public void testNoWorkDirMigration() {
jnlpLauncher.getWorkDirSettings().isDisabled());
}
+ @Issue("JENKINS-73011")
+ @SuppressWarnings("deprecation")
+ @Test
+ public void deprecatedFields() throws Exception {
+ var launcher = new JNLPLauncher();
+ launcher.setWebSocket(true);
+ launcher.setWorkDirSettings(new RemotingWorkDirSettings(false, null, "remoting2", false));
+ launcher.setTunnel("someproxy");
+ var agent = j.createSlave();
+ agent.setLauncher(launcher);
+ agent = j.configRoundtrip(agent);
+ launcher = (JNLPLauncher) agent.getLauncher();
+ assertThat(launcher.isWebSocket(), is(true));
+ assertThat(launcher.getWorkDirSettings().getInternalDir(), is("remoting2"));
+ assertThat(launcher.getTunnel(), is("someproxy"));
+ launcher = new JNLPLauncher();
+ launcher.setWebSocket(true);
+ agent.setLauncher(launcher);
+ agent = j.configRoundtrip(agent);
+ launcher = (JNLPLauncher) agent.getLauncher();
+ assertThat(launcher.isWebSocket(), is(true));
+ assertThat(launcher.getWorkDirSettings().getInternalDir(), is("remoting"));
+ assertThat(launcher.getTunnel(), nullValue());
+ }
+
@Test
public void testDefaults() {
assertFalse("Work directory enabled by default", new JNLPLauncher().getWorkDirSettings().isDisabled());