Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent config get's ignored if defaultConfig is disabled #792

Open
SylivanKenobi opened this issue Jan 17, 2023 · 0 comments · May be fixed by #803
Open

Agent config get's ignored if defaultConfig is disabled #792

SylivanKenobi opened this issue Jan 17, 2023 · 0 comments · May be fixed by #803
Labels
bug Something isn't working

Comments

@SylivanKenobi
Copy link
Contributor

SylivanKenobi commented Jan 17, 2023 •
edited
Loading

Describe the bug

If you disable controller.JCasC.defaultConfig while the agent config is enabled the agents don't get configured. The Agent config gets added to the default config in the _helpers.tpl this defaultConfig only get applied if controller.JCasC.defaultConfig is enabled. For me as a User it isn't clear that the Agent Config is part of the defaultConfig. So either the documentation has to be updated or the way the defaultConfig gets handeld should change.

Version of Helm and Kubernetes

- Helm: v3.10.3
- Kubernetes: v1.19.1

Chart version

jenkins-4.2.21

What happened?

1. Configure `agent`
2. Disable `controller.JCasC.defaultConfig`
3. `helm template` and agent config doesn't showup

What you expected to happen?

Agent is configured

How to reproduce it

No response

Anything else we need to know?

No response
@SylivanKenobi SylivanKenobi added the bug Something isn't working label Jan 17, 2023
@SylivanKenobi SylivanKenobi linked a pull request Feb 17, 2023 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor kubernetes config SylivanKenobi/helm-charts
1 participant
@SylivanKenobi