Skip to content

Conversation

@jetersen
Copy link
Member

update parent POM to 3.48 and Jenkins to 2.60.3 since java level is set to 8

clean up the POM and fix mockito to test scope.

<classifier>tests</classifier> removed from workflow-step-api to make hpi:run have none conflicting versions of workflow-step-api

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pom.xml Outdated
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<version>2.7.21</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plugin POM offers the version, will be critical for Java 11 testing

@jetersen jetersen added the chore label Jul 31, 2019
@jetersen jetersen merged commit a52167e into jenkinsci:master Jul 31, 2019
@jetersen jetersen deleted the fix/pom branch July 31, 2019 14:26
@jetersen jetersen changed the title update POM update parent POM and cleanup pom Jul 31, 2019
@jetersen jetersen mentioned this pull request Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants