Merge pull request #60 from NotMyFault/jdk21

Update dependencies to support Java 21

Author: jglick

.mvn/extensions.xml

@@ -2,6 +2,6 @@
   <extension>
     <groupId>io.jenkins.tools.incrementals</groupId>
     <artifactId>git-changelist-maven-extension</artifactId>
-    <version>1.4</version>
+    <version>1.6</version>
   </extension>
 </extensions>

pom.xml

@@ -4,7 +4,7 @@
     <parent>
         <groupId>org.jenkins-ci</groupId>
         <artifactId>jenkins</artifactId>
-        <version>1.88</version>
+        <version>1.99</version>
         <relativePath/>
     </parent>
     <groupId>org.jenkins-ci.test</groupId>
@@ -56,12 +56,14 @@
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <spotbugs.failOnError>false</spotbugs.failOnError> <!-- TODO -->
         <maven.compiler.release>8</maven.compiler.release> <!-- TODO until dropping Java 8 support in consuming plugins -->
+        <!-- TODO triage violations -->
+        <spotbugs.threshold>High</spotbugs.threshold>
     </properties>
     <dependencies>
         <dependency>
             <groupId>commons-io</groupId>
             <artifactId>commons-io</artifactId>
-            <version>2.11.0</version>
+            <version>2.13.0</version>
         </dependency>
         <dependency>
             <groupId>org.jenkins-ci</groupId>
@@ -71,7 +73,7 @@
         <dependency>
             <groupId>com.fasterxml.jackson.core</groupId>
             <artifactId>jackson-databind</artifactId>
-            <version>2.13.4</version>
+            <version>2.15.2</version>
         </dependency>
         <dependency>
             <groupId>org.jenkins-ci</groupId>
@@ -98,9 +100,14 @@
         <dependency>
             <groupId>org.mockito</groupId>
             <artifactId>mockito-core</artifactId>
-            <version>4.8.0</version>
+            <version>4.9.0</version>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>com.github.spotbugs</groupId>
+            <artifactId>spotbugs-annotations</artifactId>
+            <optional>true</optional>
+        </dependency>
     </dependencies>
     <profiles>
         <profile>

src/main/java/org/jenkinsci/test/acceptance/docker/Docker.java

@@ -1,5 +1,6 @@
 package org.jenkinsci.test.acceptance.docker;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.apache.commons.io.FileUtils;
 import org.apache.commons.io.IOUtils;
 import org.jenkinsci.utils.process.CommandBuilder;
@@ -83,6 +84,7 @@ private DockerImage build(String image, File dir) throws IOException, Interrupte
         return build(image, dir, null);
     }
 
+    @SuppressFBWarnings(value = "MS_SHOULD_BE_FINAL", justification = "TODO needs triage")
     public static boolean NO_CACHE;
 
     /**

src/main/java/org/jenkinsci/test/acceptance/docker/Resource.java

@@ -1,5 +1,6 @@
 package org.jenkinsci.test.acceptance.docker;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.apache.commons.io.IOUtils;
 
 import java.io.File;
@@ -39,6 +40,7 @@ public InputStream asInputStream() {
         }
     }
 
+    @SuppressFBWarnings(value = "DM_DEFAULT_ENCODING", justification = "TODO needs triage")
     public Reader asReader() {
         try {
             return new InputStreamReader(url.openStream());

src/main/java/org/jenkinsci/test/acceptance/docker/fixtures/SshdContainer.java

@@ -1,5 +1,6 @@
 package org.jenkinsci.test.acceptance.docker.fixtures;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.apache.commons.io.FileUtils;
 import org.apache.commons.lang3.SystemUtils;
 import org.jenkinsci.test.acceptance.docker.DockerContainer;
@@ -63,6 +64,7 @@ public File getEncryptedPrivateKey() {
         return privateKeyEnc;
     }
 
+    @SuppressFBWarnings(value = "DM_DEFAULT_ENCODING", justification = "TODO needs triage")
     public String getPrivateKeyString() {
         try {
             return new String(Files.readAllBytes(getPrivateKey().toPath()));