Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom symbols can be themeable #91

Closed
NotMyFault opened this issue Jul 20, 2022 · 2 comments · Fixed by #95
Closed

Custom symbols can be themeable #91

NotMyFault opened this issue Jul 20, 2022 · 2 comments · Fixed by #95

Comments

@NotMyFault
Copy link
Member

Describe your use-case which is not covered by existing documentation.

If custom symbols have a stroke set, they are themable, core replaces the value with currentColor to make those symbols reactive to themes.
We should probably outline that on the symbols page, considering people may use custom SVGs which have no property set, leading to unthemable symbols.

Reference any relevant documentation, other materials or issues/pull requests that can be used for inspiration.

No response

@uhafner
Copy link
Member

uhafner commented Jul 21, 2022

Is there a lint for SVG available that checks this?

@timja
Copy link
Member

timja commented Jul 21, 2022

Is there a lint for SVG available that checks this?

It may not be desirable in all cases, i.e. logos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants