-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a badge CSS style for tables #42
Comments
cc @janfaracik |
Good idea! :) I'm working on just that for the eventual plugins manager redesign as demoed way back in the day on the UX sig. It'll be as simple as adding a colour class e.g. |
I've opened a PR for this jenkinsci/jenkins#6538 :) |
Ok thanks! If I understand correctly, jenkinsci/jenkins#6538 only adds the colors. That means the badge still is not available as a separate CSS class? |
If I'm understanding correctly, you'd want the 'badge' component on a page, not inside a table? Currently the badge has to be inside a table, I can work on changing that if so 👍 |
No, I actually want the badge in the table but I did only manage to get the badge ( But having the badge as a separate concept globally would make sense as well 😄 |
Will welcome the badge as extra component as well |
What feature do you want to see added?
For table cells we currently have the styling
to show a badge-style link for model elements:
It would be helpful for plugins like the warnings and code coverage plugins (and maybe a lot of otheres), if there would be similar stylings available to show plugin results with a specific color. E.g. the code coverage as a percentage, where the background color can be customized by the plugin, e.g. red on bad coverage results, green for good, etc.
I tried to extract that part of the CSS from our Jenkins styles but I must admit that I did not understand how you achieved this existing styling in our complex CSS and LESS structure. Additionally, it might make sense if we would provide such kind of styling in a general way in Jenkins, so other plugins would not reinvent the wheel.
Upstream changes
No response
The text was updated successfully, but these errors were encountered: