Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip docs need to explain Jenkins behavior changes #177

Open
daniel-beck opened this issue Nov 28, 2022 · 2 comments
Open

Tooltip docs need to explain Jenkins behavior changes #177

daniel-beck opened this issue Nov 28, 2022 · 2 comments

Comments

@daniel-beck
Copy link
Member

Describe your use-case which is not covered by existing documentation.

https://weekly.ci.jenkins.io/design-library/Tooltips/ does not mention that the behavior of tooltip has changed over time. As a result in invites developers to introduce XSS vulnerabilities in their code by letting them assume that tooltip has always behaved as documented.

Any plugin that is compatible with Jenkins before the introduction of html-tooltip needs to escape or sanitize content of tooltip.

Reference any relevant documentation, other materials or issues/pull requests that can be used for inspiration.

No response

@uhafner
Copy link
Member

uhafner commented Nov 28, 2022

What is also missing: how can I make tooltips backward compatible: what needs to be done if I want to use HTML tooltips in Jenkins 2.380 and in the LTS 2.361.4? Should I use tooltip, html-tooltip, or data-html-tooltip? Or a mix?

@timja
Copy link
Member

timja commented Nov 28, 2022

For backwards compatibility set both tooltip and data-html-tooltip. tooltip will be ignored if the html one is set on new versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants