-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-62910] Table to div compatibility + Update the minimum Jenkins core requirement to 2.204.6 + Update Parent POM to a recent version #21
Conversation
AFAICT I can't seem to break this, the configuration saves correctly. CC: @fqueiruga , @timja In case you guys want to look, but I cannot seem to cause the typical issues with the latest version of Jenkins. I've updated the POM for convenience. |
only certain cases break it, normally to do with nested table tags or repeatable elements. It's hard to tell what will break it too. |
If its not going to break in this case, we should just migrate from a table to a div then. WDYT? |
only if you bump the baseline to 2.265 you can do that. |
Confirming that there is a case where it breaks, thanks to a user for providing a reproducible example. CC: @oleg-nenashev IIRC has permissions to release this. |
Yes. This issue is one of the reasons why I asked for permissions. Will review/merge shortly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is any concern, I suggest that we cut a compatible version for 2.204 and then, if things still fail for 2.265, work on a new release for 2.265+ which switches to the new config entirely
Will merge once green |
A user reported that he tested the new version with 2.266, so I don't anticipate issues but in case there is the path forward is clear. |
Starting a draft PR first, mostly to make sure its working with CI / incrementals