Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-62910] Table to div compatibility + Update the minimum Jenkins core requirement to 2.204.6 + Update Parent POM to a recent version #21

Merged
merged 4 commits into from
Nov 11, 2020

Conversation

res0nance
Copy link
Contributor

@res0nance res0nance commented Nov 10, 2020

Starting a draft PR first, mostly to make sure its working with CI / incrementals

@res0nance
Copy link
Contributor Author

AFAICT I can't seem to break this, the configuration saves correctly.

CC: @fqueiruga , @timja In case you guys want to look, but I cannot seem to cause the typical issues with the latest version of Jenkins. I've updated the POM for convenience.

pom.xml Outdated Show resolved Hide resolved
@timja
Copy link
Member

timja commented Nov 11, 2020

AFAICT I can't seem to break this, the configuration saves correctly.

CC: @fqueiruga , @timja In case you guys want to look, but I cannot seem to cause the typical issues with the latest version of Jenkins. I've updated the POM for convenience.

only certain cases break it, normally to do with nested table tags or repeatable elements.

It's hard to tell what will break it too.

@res0nance
Copy link
Contributor Author

AFAICT I can't seem to break this, the configuration saves correctly.
CC: @fqueiruga , @timja In case you guys want to look, but I cannot seem to cause the typical issues with the latest version of Jenkins. I've updated the POM for convenience.

only certain cases break it, normally to do with nested table tags or repeatable elements.

It's hard to tell what will break it too.

If its not going to break in this case, we should just migrate from a table to a div then. WDYT?

@timja
Copy link
Member

timja commented Nov 11, 2020

AFAICT I can't seem to break this, the configuration saves correctly.
CC: @fqueiruga , @timja In case you guys want to look, but I cannot seem to cause the typical issues with the latest version of Jenkins. I've updated the POM for convenience.

only certain cases break it, normally to do with nested table tags or repeatable elements.
It's hard to tell what will break it too.

If its not going to break in this case, we should just migrate from a table to a div then. WDYT?

only if you bump the baseline to 2.265 you can do that.

@res0nance res0nance marked this pull request as ready for review November 11, 2020 11:21
@res0nance
Copy link
Contributor Author

Confirming that there is a case where it breaks, thanks to a user for providing a reproducible example.

CC: @oleg-nenashev IIRC has permissions to release this.

@oleg-nenashev
Copy link
Member

Yes. This issue is one of the reasons why I asked for permissions. Will review/merge shortly

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is any concern, I suggest that we cut a compatible version for 2.204 and then, if things still fail for 2.265, work on a new release for 2.265+ which switches to the new config entirely

@oleg-nenashev
Copy link
Member

Will merge once green

@res0nance
Copy link
Contributor Author

If there is any concern, I suggest that we cut a compatible version for 2.204 and then, if things still fail for 2.265, work on a new release for 2.265+ which switches to the new config entirely

A user reported that he tested the new version with 2.266, so I don't anticipate issues but in case there is the path forward is clear.

@oleg-nenashev oleg-nenashev merged commit eaef2ef into jenkinsci:master Nov 11, 2020
@oleg-nenashev oleg-nenashev changed the title [JENKINS-62910] Table to div compatibility [JENKINS-62910] Table to div compatibility + Update the minimum Jenkins core requirement to 2.204.6 + Update Parent POM to a recent version Nov 11, 2020
@oleg-nenashev oleg-nenashev added chore Maintenance dependencies Dependency updates labels Nov 11, 2020
@res0nance res0nance deleted the updates branch November 11, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance dependencies Dependency updates enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants