Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jx upgrade boot wipes user requirements #5896

Closed
daveconde opened this issue Oct 22, 2019 · 0 comments · Fixed by #5912
Closed

jx upgrade boot wipes user requirements #5896

daveconde opened this issue Oct 22, 2019 · 0 comments · Fixed by #5912
Assignees
Labels
area/boot issues in the `jx boot` command area/fox area/upgrade kind/bug Issue is a bug priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@daveconde
Copy link
Contributor

Summary

When running jx upgrade boot some user modifications to jx-requirements.yml can be wiped. This is due to the cherry picking commits from the boot config repository in to the dev env repository that defaults to accept theirs when a conflict is found. This can be seen below

// CherryPickTheirs does a git cherry-pick of commit func (g *GitCLI) CherryPickTheirs(dir string, commitish string) error { return g.gitCmd(dir, "cherry-pick", commitish, "--strategy=recursive", "-X", "theirs") }

We should exclude jx-requirements.yml from the cherry pick and find a way to correctly merge the changes.

Expected behavior

After running jx upgrade boot the jx-requirements.yml contains both user changed settings and updates from the upstream boot repo.

Actual behavior

After running jx upgrade boot the jx-requirements.yml is missing user changed settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/boot issues in the `jx boot` command area/fox area/upgrade kind/bug Issue is a bug priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
3 participants