-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow slash in name #388
base: main
Are you sure you want to change the base?
Allow slash in name #388
Conversation
Hi @XLordalX. Thanks for your PR. I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/assign @ankitm123 |
Tests would be good to ensure we don't add regression. I added some changes to support nested gitlab repos, I must have missed certain parts. Thanks for looking into this and fixing it :) |
Does it fix issues around jx pipeline start? Curious ... |
Yes it does, it gets stuck on the pipeline wait command because it's waiting for the wrong trigger:
notice how it's attempting to wait for |
Did u try --nested-repo flag when importing? |
Yes. This is with —nested-repo. |
@ankitm123 I'm willing to write tests for this, but I'm not sure what needs to be tested. Can you help me out a bit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the wrong fix for the problem. The method is meant for creating k8s resource names and they can not have /. Instead some other method (possibly new) should be used.
This adds GitLab nested group support to pipelines.