Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins/infra.ci.jenkins.io/website-jobs/jenkins.io/pr-merge appears to be failing consistently #4476

Closed
kmartens27 opened this issue Jan 6, 2025 · 5 comments
Assignees

Comments

@kmartens27
Copy link
Collaborator

kmartens27 commented Jan 6, 2025

Service(s)

jenkins.io

Summary

Open (and some closed) Jenkins.io pull requests appear to be failing the
jenkins/infra.ci.jenkins.io/website-jobs/jenkins.io/pr-merge check consistently if they pull the master branch updates or have been created in the last few days. When trying to navigate to the failure to get further information, the browser is unable to reach a connection.

This appears to prevent the deploy preview from being built (preventing a preview of any changes or additions).

Example PRs:
jenkins-infra/jenkins.io#7772
jenkins-infra/jenkins.io#7793
jenkins-infra/jenkins.io#7764 - created 3 weeks ago
jenkins-infra/jenkins.io#7761 - created 3 weeks ago (shows all checks passed at different points, deploy preview available on previous builds)
jenkins-infra/jenkins.io#7797 - closed (error not blocking merge)

jenkins-infra/jenkins.io#7796 - merged with this check passing 4 days ago

Error when trying to view details:
Screenshot 2025-01-06 at 3 41 32 PM

Reproduction steps

Create a new pull request on jenkins.io or pull updates into existing open pull request
Allow the updates to finish and review the checks

@kmartens27 kmartens27 added the triage Incoming issues that need review label Jan 6, 2025
@smerle33
Copy link
Contributor

smerle33 commented Jan 7, 2025

seems related to this error in the build stage:

07:43:22  bundler: failed to load command: awestruct (/home/jenkins/workspace/website-jobs_jenkins.io_PR-7764/vendor/gems/ruby/3.4.0/bin/awestruct)

07:43:22  /home/jenkins/workspace/website-jobs_jenkins.io_PR-7764/vendor/gems/ruby/3.4.0/gems/em-websocket-0.5.3/lib/em-websocket/handshake04.rb:2:in 'Kernel#require': cannot load such file -- base64 (LoadError)

the ruby version have been bumped 5 days ago with https://github.com/jenkins-infra/packer-images/releases/tag/2.20.0 including this PR https://github.com/jenkins-infra/packer-images/pull/1624/files

And this PR explain the fact that base64 is not included in the default gems starting from Ruby 3.4 igrigorik/em-websocket#161

@smerle33
Copy link
Contributor

smerle33 commented Jan 7, 2025

the pipelines on ci.jenkins.io (public) and infra.ci.jenkins.io (private: require VPN) are not the same, and not using the same ruby version. The error, only affect the website previews but not the CI nor CD part, so you can still publish changes.
We will try to find a solution for the "missing" Gem.

@smerle33 smerle33 removed the triage Incoming issues that need review label Jan 7, 2025
@smerle33 smerle33 self-assigned this Jan 7, 2025
@smerle33 smerle33 added this to the infra-team-sync-2025-01-14 milestone Jan 7, 2025
@kmartens27
Copy link
Collaborator Author

thanks very much for the insight and work @smerle33, I appreciate it! It's definitely not a blocker since everything can still be merged and what not, it was originally raised by a user that I was working with on a pull request.

@smerle33
Copy link
Contributor

smerle33 commented Jan 8, 2025

issue solved by setting the base64 gem in the depency file.
we need to improve the updatecli process to keep the ruby version for the ci process aligned with the infra one. issue todo

@smerle33 smerle33 closed this as completed Jan 8, 2025
@kmartens27
Copy link
Collaborator Author

thanks very much @smerle33 for the fix, everything looks good and deploy previews are working again from what I have seen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants