Skip to content

Commit 01810a8

Browse files
committed
fix: handle v prefix in devcontainer version patterns
The devcontainer.json file has version values with v prefixes (e.g., v27.0.3, v2.83.1), but the updatecli patterns did not account for this, causing pattern match failures. Updated patterns to include optional v prefix using v? This allows the patterns to match both with and without v prefix.
1 parent b4e5283 commit 01810a8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

updatecli/updatecli.d/devcontainer.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ targets:
4444
sourceid: dockerLatestMinor
4545
spec:
4646
file: .devcontainer/devcontainer.json
47-
matchpattern: '("version": ")([0-9.]*)(",)'
47+
matchpattern: '("version": "v?)([0-9.]*)(",)'
4848
replacepattern: '${1}{{ source "dockerLatestMinor" }}${3}'
4949
search:
5050
pattern: 'ghcr\.io/devcontainers/features/docker-in-docker'
@@ -58,7 +58,7 @@ targets:
5858
sourceid: githubcliLatestMinor
5959
spec:
6060
file: .devcontainer/devcontainer.json
61-
matchpattern: '("version": ")([0-9.]+)(")'
61+
matchpattern: '("version": "v?)([0-9.]+)(")'
6262
replacepattern: '${1}{{ source "githubcliLatestMinor" }}${3}'
6363
search:
6464
pattern: 'ghcr\.io/devcontainers/features/github-cli'

0 commit comments

Comments
 (0)