Keep up with changes in geventhttpclient #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerchunPak
commented
Apr 28, 2024
| @@ -257,7 +257,7 @@ def swift_auth_v1(self): | |||
| if ret.status_code < 200 or ret.status_code >= 300: | |||
| raise SwiftException( | |||
| "AUTH v1.0 request failed on " | |||
| + f"{str(auth_httpclient.get_base_url()) + path} with error code {ret.status_code} ({ret.items()!s})" | |||
| + f"{self.auth_url} with error code {ret.status_code} ({ret.items()!s})" | |||
There was a problem hiding this comment.
I am not sure if this information is safe to print, I am also unsure why the author of this code used auth_httpclient.get_base_url instead of self.auth_url and if they are equal
There was a problem hiding this comment.
Let's optimistically assume this is okay. If we're wrong, we can revert and add a comment (and add a comment)
jelmer
approved these changes
May 3, 2024
jelmer
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1279