Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to node 16 and v3 package lock format #225

Closed
thornbill opened this issue Aug 19, 2022 · 4 comments · Fixed by #250
Closed

Update to node 16 and v3 package lock format #225

thornbill opened this issue Aug 19, 2022 · 4 comments · Fixed by #250
Labels
cleanup Cleanup of legacy code or code smells github_actions Pull requests that update Github_actions code good first issue Good for newcomers

Comments

@thornbill
Copy link
Member

thornbill commented Aug 19, 2022 •
edited
Loading

Our workflows are still using node 14 and 16 is the current LTS. We should update the workflows to use node 16 and update the package-lock.json to the v2 v3 format used by newer versions of npm.
@thornbill thornbill added good first issue Good for newcomers github_actions Pull requests that update Github_actions code cleanup Cleanup of legacy code or code smells labels Aug 19, 2022
@fk00750
Copy link

fk00750 commented Aug 19, 2022

Hey can you assign me this issue

@ferferga
Copy link
Member

Why not v3 directly?

@thornbill
Copy link
Member Author

@ferferga does renovate support v3? I honestly did not know they had already incremented it again.

@ferferga
Copy link
Member

@thornbill Yes, we use it in Vue since day 1.

Much faster at installing packages and you can enforce it using .npmrc

@thornbill thornbill changed the title Update to node 16 and v2 package lock format Update to node 16 and v3 package lock format Aug 26, 2022
@ferferga ferferga mentioned this issue Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Cleanup of legacy code or code smells github_actions Pull requests that update Github_actions code good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Node 16, lockfile v3 and Renovate jellyfin/jellyfin-sdk-typescript
3 participants
@thornbill @ferferga @fk00750