Merge pull request #1556 from cewert/fix-whatsnew

Fix what's new popup and show it for each user if enabled

Author: 1hitsong

components/WhatsNewDialog.bs

@@ -5,7 +5,7 @@ sub init()
 
     m.top.id = "OKDialog"
     m.top.height = 900
-    m.top.title = "What's New?"
+    m.top.title = m.global.app.version + " - " + tr("What's New?")
     m.top.buttons = [tr("OK")]
 
     dialogStyles = {
@@ -21,7 +21,7 @@ sub init()
         }
     }
 
-    whatsNewList = ParseJSON(ReadAsciiFile("pkg:/source/static/whatsNew.json"))
+    whatsNewList = ParseJSON(ReadAsciiFile("pkg:/source/static/whatsNew/" + m.global.app.version.ToStr().trim() + ".json"))
 
     for each item in whatsNewList
         textLine = m.content.CreateChild("StdDlgMultiStyleTextItem")

locale/en_US/translations.ts

@@ -1241,5 +1241,10 @@
             <translation>Make the arrangement of the Roku home view sections match the web client's home screen. Jellyfin will need to be closed and reopened for change to take effect.</translation>
             <extracomment>User Setting - Setting description</extracomment>
         </message>
+        <message>
+            <source>What's New?</source>
+            <translation>What's New?</translation>
+            <extracomment>Popup title - Popup displays all the major changes to the app since the last version</extracomment>
+        </message>
     </context>
 </TS>

source/Main.bs

@@ -20,10 +20,8 @@ sub Main (args as dynamic) as void
     m.wasMigrated = false
     runGlobalMigrations()
     runRegistryUserMigrations()
-    ' update LastRunVersion now that migrations are finished
-    showWhatsNew = false
+    ' update global LastRunVersion now that migrations are finished
     if m.global.app.version <> m.global.app.lastRunVersion
-        showWhatsNew = true
         set_setting("LastRunVersion", m.global.app.version)
     end if
     if m.wasMigrated then printRegistry()
@@ -74,11 +72,16 @@ sub Main (args as dynamic) as void
         end if
     end if
 
-    ' Show the Whats New popup
-    if showWhatsNew and m.global.session.user.settings["load.allowwhatsnew"]
-        dialog = createObject("roSGNode", "WhatsNewDialog")
-        m.scene.dialog = dialog
-        m.scene.dialog.observeField("buttonSelected", m.port)
+    ' has the current user ran this version before?
+    usersLastRunVersion = m.global.session.user.settings.lastRunVersion
+    if not isValid(usersLastRunVersion) or not versionChecker(m.global.session.user.settings.lastRunVersion, m.global.app.version)
+        set_user_setting("LastRunVersion", m.global.app.version)
+        ' show what's new popup
+        if m.global.session.user.settings["load.allowwhatsnew"]
+            dialog = createObject("roSGNode", "WhatsNewDialog")
+            m.scene.dialog = dialog
+            m.scene.dialog.observeField("buttonSelected", m.port)
+        end if
     end if
 
     ' Handle input messages

source/migrations.bs

@@ -71,7 +71,7 @@ sub runRegistryUserMigrations()
                 ' app versions < 2.0.0 didn't save LastRunVersion at the user level
                 ' fall back to using the apps lastRunVersion
                 lastRunVersion = m.global.app.lastRunVersion
-                registry_write("LastRunVersion", m.global.app.version, section)
+                registry_write("LastRunVersion", lastRunVersion, section)
             end if
 
             ' BASE_MIGRATION