Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Chromecast Integration #1298

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

Improving Chromecast Integration #1298

wants to merge 18 commits into from

Commits on Feb 14, 2024

  1. call success callback when result was successfull

    Christopher Hoch committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    44ef035 View commit details
    Browse the repository at this point in the history

  2. fix service start on android O+

    Christopher Hoch committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    1971a0e View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. bind service according to android example 

    https://developer.android.com/develop/background-work/services/bound-services
    Christopher Hoch committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    9b8c079 View commit details
    Browse the repository at this point in the history

  2. use ContextCompat to start foreground services

    Christopher Hoch committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    5339115 View commit details
    Browse the repository at this point in the history

  3. use ContextCompat to start foreground services

    Christopher Hoch committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    d10cde8 View commit details
    Browse the repository at this point in the history

  4. release wake lock on stop

    Christopher Hoch committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    c05c742 View commit details
    Browse the repository at this point in the history

  5. reduce wake lock time, but call it more often

    Christopher Hoch committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    1753fbc View commit details
    Browse the repository at this point in the history

  6. onShutdown: 

    wait for 15 seconds before actually shutting down.
this is because chromecast playback somethimes seems to play a track and when that one stops, plays another.
That means, that stop is called in the mean time which causes the notification to disappear and the wake lock to be released which can cause errors an restarting the background service. to prevent this we wait 15 seconds before actually stopping the service, giving chromecast/jellyfin client time to start another track.
    Christopher Hoch committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    4824ceb View commit details
    Browse the repository at this point in the history

  7. startForeground, bind to notification to enable foreground service fo… 

    …r playback
    Christopher Hoch committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    78a0b28 View commit details
    Browse the repository at this point in the history

  8. debug logging in RemotePlayerService

    Christopher Hoch committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    0375c63 View commit details
    Browse the repository at this point in the history

  9. manifest: service enabled and set foreground type

    Christopher Hoch committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    6752858 View commit details
    Browse the repository at this point in the history

  10. lint

    Christopher Hoch committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    0879950 View commit details
    Browse the repository at this point in the history

  11. lint

    Christopher Hoch committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    37ffffa View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. add wake lock

    Christopher Hoch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f444d07 View commit details
    Browse the repository at this point in the history

  2. merged master from jellyfin

    Christopher Hoch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    efaefc1 View commit details
    Browse the repository at this point in the history

  3. unbind on destroy rather than on stop. call through super in onUserLe… 

    …aveHint
    Christopher Hoch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    14d632e View commit details
    Browse the repository at this point in the history

  4. do not stop running sessions on destroy

    Christopher Hoch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    40c0efd View commit details
    Browse the repository at this point in the history

  5. calm the lint

    Christopher Hoch committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    ea92dff View commit details
    Browse the repository at this point in the history