Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow more isolated use of Jekyll::Paginate::Pager #26

Open
stevecrozz opened this issue Feb 19, 2015 · 1 comment
Open

allow more isolated use of Jekyll::Paginate::Pager #26

stevecrozz opened this issue Feb 19, 2015 · 1 comment

Comments

@stevecrozz
Copy link

I'm using Jekyll::Paginate::Pager to build tag indexes for my blog: https://github.com/stevecrozz/lithostech.com/blob/master/_plugins/tag_indexes.rb

But since this class references site.config inside ::paginate_path (https://github.com/jekyll/jekyll-paginate/blob/master/lib/jekyll-paginate/pager.rb#L66) I cannot reuse this class for paginating anything that doesn't share the same 'paginate_path.' I propose we modify the ::paginate_path method to accept config as an argument so I can reuse it.

If you agree, I can supply a PR and a test case.

@parkr
Copy link
Member

parkr commented Mar 16, 2015

It's all mixed up and crazy. Working on fixing it up in #22, but I don't have the energy and interest right now. Feel free to complete that work if you have free time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants