From 43f5109b01cc70edeaf543498d1799279dae4070 Mon Sep 17 00:00:00 2001 From: chelkyl <14041823+chelkyl@users.noreply.github.com> Date: Mon, 25 Apr 2022 19:57:09 -0500 Subject: [PATCH 1/2] fix: also fail if either new or removed typings not only when both --- src/cli.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/cli.ts b/src/cli.ts index 8046e4a..d7d3e7f 100644 --- a/src/cli.ts +++ b/src/cli.ts @@ -71,8 +71,7 @@ async function run(syncer: ITypeSyncer) { ) if ( flags.dry === 'fail' && - totals.newTypings > 0 && - totals.removedTypings > 0 + (totals.newTypings > 0 || totals.removedTypings > 0) ) { C.error('Typings changed; check failed.') process.exitCode = 1 From 0d5589d882fca46e1f6ee84657ebbe5875ca1805 Mon Sep 17 00:00:00 2001 From: chelkyl <14041823+chelkyl@users.noreply.github.com> Date: Tue, 26 Apr 2022 17:24:34 -0500 Subject: [PATCH 2/2] ci: node 18 requires glibc >= 2.28 focal is the latest Ubuntu version that Travis CI supports --- .travis.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.travis.yml b/.travis.yml index e1b8b71..dd0b2f6 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,6 +1,9 @@ # Oh yeah! language: node_js +# Node 18 binaries require glibc >= 2.28 +dist: focal + # Add additional versions here as appropriate. node_js: - 'stable'