Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix diffing #94

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Fix diffing #94

merged 2 commits into from
Jan 31, 2023
+44 −7

Conversation

oreshinya
Copy link
Contributor

@oreshinya oreshinya commented Jan 30, 2023 •
edited
Loading

Dry run with ignoreDeps: [ "dev" ] always fails, because ignoreDeps: [ "dev" ] ignores all dev deps including @types/ and diffing detect always new @types/ packages.

@coveralls
Copy link
Collaborator

coveralls commented Jan 30, 2023 •
edited
Loading

Coverage Status

Coverage: 100.0%. Remained the same when pulling c8a21e0 on oreshinya:fix_diffing into d07630d on jeffijoe:master.

jeffijoe
jeffijoe reviewed Jan 30, 2023
View reviewed changes
Copy link
Owner

@jeffijoe jeffijoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Let me know what you think about my suggestion.

src/type-syncer.ts Outdated Show resolved Hide resolved
@jeffijoe jeffijoe merged commit 732d2f1 into jeffijoe:master Jan 31, 2023
@jeffijoe
Copy link
Owner

Thanks again, this was released as v0.10.0! I had to change the CI to GitHub Actions since my Travis credits ran out.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffijoe jeffijoe jeffijoe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oreshinya @coveralls @jeffijoe