Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

honor yarn save-exact setting #12

Closed
dylang opened this issue Sep 20, 2018 · 5 comments
Closed

honor yarn save-exact setting #12

dylang opened this issue Sep 20, 2018 · 5 comments

Comments

@dylang
Copy link

dylang commented Sep 20, 2018

We use renovate to keep our dependencies up-to-date, and it recommends not including ^ or ~ in the semver version in package.json files so that it can test all version upgrades before merging them.

yarn has a setting for this:

save-exact true

It would be helpful if typesync honored that config.

There might be a similar setting for npm.

@jeffijoe
Copy link
Owner

Currently typesync always adds the latest version of typings, but maybe it should look for a version that matches the semver of the package and write it out in the same format. That's more work though, and not sure if it's that valuable. If yarn upgrade-interactive still lists updates for packages with no prefixed version, I would not be opposed to making typesync write the exact version always.

@dylang
Copy link
Author

dylang commented Sep 21, 2018

That sounds like an even better idea, good thinking!

@jeffijoe
Copy link
Owner

I always use prefixes so I don't know how yarn upgrade-interactive works in that case. Could you verify this for me please?

@jeffijoe
Copy link
Owner

jeffijoe commented Oct 8, 2018

Implemented as of v0.4.0.

@jeffijoe jeffijoe closed this as completed Oct 8, 2018
@dylang
Copy link
Author

dylang commented Oct 19, 2018

Amazing job, works great!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants