feat(cloudflare): support comment param
#980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: WaterLemons2k <[email protected]>
Co-authored-by: WaterLemons2k <[email protected]>
jeessy2
reviewed
Jan 14, 2024
| zoneID := result.Result[0].ID | ||
|
|
||
| var records CloudflareRecordsResp | ||
| // getDomains 最多更新前50条 | ||
| err = cf.request( | ||
| "GET", | ||
| fmt.Sprintf(zonesAPI+"/%s/dns_records?type=%s&name=%s&per_page=50", zoneID, recordType, domain), | ||
| fmt.Sprintf(zonesAPI+"/%s/dns_records?type=%s&name=%s&per_page=50%s", zoneID, recordType, domain, comment), |
There was a problem hiding this comment.
`fmt.Sprintf(zonesAPI+"/%s/dns_records?type=%s&name=%s&per_page=50&comment=%s", zoneID, recordType, domain, domain.GetCustomParams().Get("comment")),`
上面那几行可以不要吧，一行搞定？
There was a problem hiding this comment.
`fmt.Sprintf(zonesAPI+"/%s/dns_records?type=%s&name=%s&per_page=50&comment=%s", zoneID, recordType, domain, domain.GetCustomParams().Get("comment")),`上面那几行可以不要吧，一行搞定？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
支持传递自定义参数
comment来对 cloudflare 的 DNS 记录进行筛选，从而利用不同 comment 实现单域名多 IP 地址的效果Motivation
同#923，需要“单域名多 IP”的支持
Additional Notes
comment参数未指定时，行为和原先一致：忽略 DNS 记录的 comment，只匹配域名，且不会修改 commentwww:example.cn.eu.org?comment=.contains等更高级的匹配模式，但对于“单域名多 IP”这一目标来说还用不到，因此暂未实现