Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(domainsHelp): indicate when separated by a colon is needed #1043

Merged
merged 2 commits into from
Mar 17, 2024

Conversation

WaterLemons2k
Copy link
Contributor

@WaterLemons2k WaterLemons2k commented Mar 17, 2024

What does this PR do?

Right now, the help text underneath the domains only states that colons can be used to separate domains, but not in which cases.

Motivation

Some users don't realize that you can split domains by using colons.

Additional Notes

There may be other words are better than "the domain is unregistrable".

Right now, it only specifies that colons can be used to separate domains, but not in which cases.
@jeessy2
Copy link
Owner

jeessy2 commented Mar 17, 2024

简化一下,占了三行

@jeessy2
Copy link
Owner

jeessy2 commented Mar 17, 2024

能不用Prettier优化代码不?优化后有些去了引号,有些又没有,代码编辑器看到有点花

Right now, it only specifies that colons can be used to separate domains, but not in which cases.
@jeessy2 jeessy2 merged commit 23f39fb into jeessy2:master Mar 17, 2024
2 checks passed
@WaterLemons2k WaterLemons2k deleted the domainsHelp branch March 17, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants