Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Positioning of videos is not quite correct #6

Open
jech opened this issue Dec 22, 2020 · 1 comment
Open

Positioning of videos is not quite correct #6

jech opened this issue Dec 22, 2020 · 1 comment

Comments

@jech
Copy link
Owner

jech commented Dec 22, 2020

The positioning of videos is not quite correct. The effect is most visible when there are exactly three videos in a tall, thin window: there are two rows, with two videos in the first row, and one in the second.

The issue lies in function resizePeers in galene.js, which simply chooses the square root of the number of videos as the number of rows. Something smarter is required.

@MisterDA
Copy link
Contributor

MisterDA commented Jan 4, 2021

This has just made Hacker News front page: https://www.alfonsobeato.net/math/the-many-ways-of-splitting-a-rectangle-in-many/
It’s square turtles all the way down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants