Skip to content

registry: add github backend for grails #7429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 1 commit into from
Dec 19, 2025
Merged

registry: add github backend for grails #7429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion registry.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1931,7 +1931,10 @@ backends = ["asdf:mise-plugins/mise-gradle-profiler"]
description = "A tool for gathering profiling and benchmarking information for Gradle builds"

[tools.grails]
backends = ["asdf:mise-plugins/mise-grails"]
backends = [
"asdf:mise-plugins/mise-grails",
"github:apache/grails-core[asset_pattern=apache-grails-{version}-bin.zip,bin_path=apache-grails-{version}-bin/bin]",
]

@cursor cursor Bot Dec 19, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Backend ordering reversed from PR stated intention

The PR description states the github backend should be the "primary" and asdf should be kept as a "fallback", but the backends array lists asdf:mise-plugins/mise-grails first and github:apache/grails-core second. In this registry, the first backend is tried first (primary), so the current ordering makes asdf primary instead of github, which is the opposite of the stated intention.

Fix in Cursor Fix in Web

@cursor cursor Bot Dec 19, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing test command mentioned in PR description

The PR description explicitly states "Add test command" as one of the changes being made, but no test field was added to the [tools.grails] entry. Neighboring tools like [tools.gradle] and [tools.grain] have test fields defined. This appears to be an incomplete implementation of the intended changes.

Fix in Cursor Fix in Web

description = "A powerful Groovy-based web application framework for the JVM built on top of Spring Boot"

[tools.grain]
Expand Down
Loading