From 6b5d1e38db34cac7a57628992a2a8566e34266b1 Mon Sep 17 00:00:00 2001 From: Taku Kodma <79110363+risu729@users.noreply.github.com> Date: Thu, 28 May 2026 06:10:28 +1000 Subject: [PATCH] fix(aqua): lock github_content raw URLs --- e2e/cli/test_lock | 11 +++++++++++ src/backend/aqua.rs | 9 +++++++-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/e2e/cli/test_lock b/e2e/cli/test_lock index 9eb8216235..9ef7855ded 100644 --- a/e2e/cli/test_lock +++ b/e2e/cli/test_lock @@ -77,6 +77,17 @@ assert_contains "echo '$output'" "Processing 1 tool(s)" assert_contains "cat mise.lock" "jqlang/jq" assert_not_contains "cat mise.lock" "mikefarah/yq" +echo "=== Testing aqua github_content lock URLs ===" +rm -f mise.lock +cat <mise.toml +[tools] +"aqua:awslabs/git-secrets" = "1.3.0" +EOF + +mise lock --platform macos-arm64 +assert_contains "cat mise.lock" 'url = "https://raw.githubusercontent.com/awslabs/git-secrets/1.3.0/git-secrets"' +assert_not_contains "cat mise.lock" "archive/refs/tags/1.3.0.tar.gz" + echo "=== Testing minimum release age filtering ===" rm -f mise.lock cat <mise.toml diff --git a/src/backend/aqua.rs b/src/backend/aqua.rs index d1b21d4a5f..bb0abb37a1 100644 --- a/src/backend/aqua.rs +++ b/src/backend/aqua.rs @@ -760,8 +760,13 @@ impl Backend for AquaBackend { } result } - AquaPackageType::GithubArchive | AquaPackageType::GithubContent => { - (Some(self.github_archive_url(&pkg, &v)), None) + AquaPackageType::GithubArchive => (Some(self.github_archive_url(&pkg, &v)), None), + AquaPackageType::GithubContent => { + if pkg.path.is_some() { + (Some(self.github_content_url(&pkg, &v)), None) + } else { + bail!("github_content package requires `path`") + } } AquaPackageType::Http => (pkg.url(&v, target_os, target_arch).ok(), None), _ => (None, None),