Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

24hr format issue #208

Closed
comtom opened this issue Feb 6, 2014 · 1 comment · May be fixed by #209
Closed

24hr format issue #208

comtom opened this issue Feb 6, 2014 · 1 comment · May be fixed by #209
Labels
enhancement i18n/l10n

Comments

@comtom
Copy link

comtom commented Feb 6, 2014

When meridian is disabled, hours should be between 00 and 23. Instead, if hours are less than ten, a one digit number shows up (0 to 9, instead of '00' to '09'.

It would be awesome to fix this as it is nicer, more consistent (minutes values work like expected) and relational databases expect a 'XX:XX' format, so I think is the best option.

Thanks for your work
@astjohn astjohn mentioned this issue Feb 10, 2014
Open
eleumik added a commit to eleumik/bootstrap-timepicker that referenced this issue May 9, 2014
@eleumik
Added support for two digits hour
7a5a84a 
this should fix jdewit#219 jdewit#209 jdewit#208 jdewit#203, jdewit#209 has tests not yet included here

JSBIN http://jsbin.com/xahux/3
@mrhota
Copy link
Collaborator

mrhota commented Aug 6, 2015

I prefer the config to be called twoDigitHour. Will fix during merge.

peichhorn-netgo pushed a commit to netgo-software/bootstrap-timepicker that referenced this issue Aug 27, 2015
Added support for two digits hour
bcdd398 
this should fix jdewit#219 jdewit#209 jdewit#208 jdewit#203, jdewit#209 has tests not yet included here

JSBIN http://jsbin.com/xahux/3

see: eleumik@7a5a84a
@comtom comtom closed this as completed Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement i18n/l10n
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 24h display when showMeridian is false. astjohn/bootstrap-timepicker
2 participants
@comtom @mrhota