-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore_cocoapods_path has been removed from Fastlane #25
Comments
I since found the fix I provided didn't quite work. I duplicated the original method into this codebase and I've got a fork available if you want to use that in the meantime. https://github.com/alpriest/settings-bundle |
Fixed in 1.3.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since the inclusion of this pull request in Fastlane, the
Fastlane::Actions.ignore_cocoapods_path
has been removed in favour ofFastlane::Helper::XcodeprojHelper
which detects Carthage and Cocoapod workspace project files.My suggestion is that settings_bundle_helper.rb:143 needs changing to:
xcodeproj_paths = Fastlane::Helper::XcodeprojHelper.find(all_xcodeproj_paths)
And then the failing test in specs/settings_bundle_helper_spec.rb need their expectations changing to expect 2 calls to the Dir method.
The text was updated successfully, but these errors were encountered: