Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore_cocoapods_path has been removed from Fastlane #25

Closed
alpriest opened this issue Feb 5, 2019 · 4 comments · Fixed by #27
Closed

ignore_cocoapods_path has been removed from Fastlane #25

alpriest opened this issue Feb 5, 2019 · 4 comments · Fixed by #27

Comments

@alpriest
Copy link

alpriest commented Feb 5, 2019

Since the inclusion of this pull request in Fastlane, the Fastlane::Actions.ignore_cocoapods_path has been removed in favour of Fastlane::Helper::XcodeprojHelper which detects Carthage and Cocoapod workspace project files.

My suggestion is that settings_bundle_helper.rb:143 needs changing to:
xcodeproj_paths = Fastlane::Helper::XcodeprojHelper.find(all_xcodeproj_paths)

And then the failing test in specs/settings_bundle_helper_spec.rb need their expectations changing to expect 2 calls to the Dir method.

@ghost
Copy link

ghost commented Feb 21, 2019

@jdee It would be really great if this issue could be addressed.

The settings-bundle plugin is broken with Fastlane versions 2.113.0 and higher due to the change @alpriest linked above.

@alpriest
Copy link
Author

I since found the fix I provided didn't quite work. I duplicated the original method into this codebase and I've got a fork available if you want to use that in the meantime.

https://github.com/alpriest/settings-bundle

@ghost
Copy link

ghost commented Feb 21, 2019

Cool, thanks for the heads up @alpriest!

We're currently using a fork which adapts the changes you made in #26 to make it work correctly. I submitted them as #27.

@jdee jdee closed this as completed in #27 May 13, 2019
@jdee
Copy link
Owner

jdee commented May 13, 2019

Fixed in 1.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants