Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only User Settings Are Honored #46

Closed
brandonaaskov opened this issue Mar 2, 2013 · 2 comments
Closed

Only User Settings Are Honored #46

brandonaaskov opened this issue Mar 2, 2013 · 2 comments

Comments

@brandonaaskov
Copy link

I noticed that the jslint_happy flag wasn't being respected, and when I copied the settings I had configured for the Default user...

{
    // exposed jsbeautifier options
    "indent_with_tabs": false,
    "preserve_newlines": true,
    "max_preserve_newlines": 4,
    "jslint_happy": true,
    "brace_style": "collapse", //collapse, expand, end-expand
    "keep_array_indentation": false,
    "keep_function_indentation": false,
    "eval_code": false,
    "unescape_strings": false,
    "break_chained_methods": false,

    // jsformat options
    "format_on_save": false
}

...and pasted them into the User settings, the flag was honored. Also, I had to dig into the code to find the brace_style options since they weren't listed in the README.

@jdavisclark
Copy link
Owner

Not sure what the deal might be with the jslint_happy flag. The plugin has no idea if the settings are coming from the user settings or default settings, sublime handles that pretty transparently. I'll try and reproduce later on.

Also, I had to dig into the code to find the brace_style options since they weren't listed in the README.

Yea, we need to get some better documentation in the readme. I just don't have time at the moment. #36 is about adding more documentation. I do accept pull requests 👍

@jdavisclark
Copy link
Owner

I'm not sure if it would have solved this for you, but I think I did identify and resolve (in v1.1.0) a potential issue with the option handling.

See if you are good to go now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants