Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spnego: Support proxy authentication #397

Open
andybalholm opened this issue Jul 11, 2020 · 3 comments
Open

spnego: Support proxy authentication #397

andybalholm opened this issue Jul 11, 2020 · 3 comments

Comments

@andybalholm
Copy link

andybalholm commented Jul 11, 2020

I'd like to add support for HTTP proxy authentication. I think the changes would basically be limited to header names and status codes:

Authorization -> Proxy-Authorization
WWW-Authenticate -> Proxy-Authenticate
http.StatusUnauthorized -> http.StatusProxyAuthRequired

The biggest question is where to put the switch between the two modes. I would suggest a new function, perhaps SPNEGOKRB5ProxyAuthenticate. Then that function and SPNEGOKRB5Authenticate would both call an unexported function with an extra parameter which would switch between regular HTTP authentication and proxy authentication.

What do you think?

@nrolans
Copy link
Contributor

nrolans commented Jul 25, 2020

I needed similar flexibility for other features and suggested PR #391. I think your use case could technically be integrated in that approach too. However be aware that it is currently pending review.

@sandy2008
Copy link

Hi! Please take a look at this PR: #535

@andybalholm
Copy link
Author

I'm glad to see it's being added, but we already found another solution to our problem, so I can't really test it at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants