-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally filter email addresses #247
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8a8e7b3
remove email addresses from first line of quote email replies
oreoshake e00d564
make email address filtering optional
oreoshake 7dff936
don't require 'pry'
oreoshake a591789
filter all email addresses from quote sections, not just the first
oreoshake 0d31166
Revert "filter all email addresses from quote sections, not just the …
oreoshake 5c6926f
update text
oreoshake 19ad2b2
filter all quoted email addresses when configured
oreoshake File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
require "test_helper" | ||
|
||
EmailReplyFilter = HTML::Pipeline::EmailReplyFilter | ||
|
||
class HTML::Pipeline::EmailReplyFilterTest < Minitest::Test | ||
def setup | ||
@body = <<-EMAIL | ||
Hey, don't send email addresses in comments. They aren't filtered. | ||
|
||
> On Mar 5, 2016, at 08:05, Boaty McBoatface <[email protected]> wrote: | ||
> | ||
> Sup. [email protected] | ||
> | ||
> — | ||
> Reply to this email directly or view it on GitHub. | ||
end | ||
|
||
def test_doesnt_hide_by_default | ||
filter = EmailReplyFilter.new(@body) | ||
doc = filter.call.to_s | ||
assert_match %r([email protected]), doc | ||
assert_match %r([email protected]), doc | ||
end | ||
|
||
def test_hides_email_addresses_when_configured | ||
filter = EmailReplyFilter.new(@body, :hide_quoted_email_addresses => true) | ||
doc = filter.call.to_s | ||
refute_match %r([email protected]), doc | ||
refute_match %r([email protected]), doc | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bug 😢
gsub!
can returnnil
.