Implement new context option: ignored_ancestor_tags to accept more ignored tags. #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def call | ||
| doc.search('text()').each do |node| | ||
| content = node.to_html | ||
| next unless content.include?(':') | ||
| next if has_ancestor?(node, %w(pre code tt)) | ||
| next if has_ancestor?(node, ignored_ancestor_tags) |
There was a problem hiding this comment.
I like this change, but I'd skip the ignored_pattern. This filter is designed to run on HTML fragments, so we should assume that tags is a reasonable input to work with.
There was a problem hiding this comment.
👍 Got it. Removed ignored_pattern.
JuanitoFatas
changed the title
|
Error due to Nokogiri 1.6.6.2 & 1.6.6.1, works on 1.6.5: |
|
Team Nokogiri is looking into this at sparklemotion/nokogiri#1233 |
simeonwillbanks
pushed a commit
that referenced
this pull request
Feb 9, 2015
- As identified in #170, nokogiri 1.6.x is buggy - Team nokogiri is working on the fix sparklemotion/nokogiri#1233 - Until the bug is fixed, define a range of working nokogiri gems
|
since #176 pinned the nokogiri version, could someone please restart the tests please 😄 ? Thanks! |
|
@JuanitoFatas you'll need to merge the latest master into your branch and push. That'll restart the build and have the changes from #176. |
|
@jch Ah right I need to rebase 😛, rebased and force pushed, please check again! 😃 |
|
👍 |
|
@JuanitoFatas I usually just do a merge from master rather than rebase and force push, but it's a matter of preference. Thanks for updating. |
jch
added a commit
that referenced
this pull request
Feb 11, 2015
…tern-for-emoji-filter Implement new context option: ignored_ancestor_tags to accept more ignored tags.
JuanitoFatas
deleted the
fix/configurable-ignore-pattern-for-emoji-filter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello maintainer,
I attempt to fix #163 by implementedignored_pattern.And while reading conversations in #163,
above quote inspired me to implement ignored_ancestor_tags.
Then we could specify more tags to stop the emojification process if we want.
Please take a look. 🙇 🙏
Thanks!!