Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to get head or base commits of a pull request #1090

Closed
cvrebert opened this issue May 26, 2015 · 3 comments · Fixed by #1125
Closed

Unable to get head or base commits of a pull request #1090

cvrebert opened this issue May 26, 2015 · 3 comments · Fixed by #1125

Comments

@cvrebert
Copy link
Contributor

Neither Pull nor Pull.Smart expose methods to access the head or base members of a pull request's JSON (see https://developer.github.com/v3/pulls/#get-a-single-pull-request ), so it doesn't seem easily possible to access this important pull request info via jcabi-github.
I therefore suggest that head() and base() methods be added to Pull.Smart.
@cvrebert cvrebert mentioned this issue May 26, 2015
Open
@cvrebert cvrebert mentioned this issue Jun 15, 2015
Merged
@dmarkov
Copy link

dmarkov commented Jun 15, 2015

@yegor256 please do something about this issue

@cvrebert
Copy link
Contributor Author

#1125 will fix this.

@dmarkov
Copy link

dmarkov commented Jun 17, 2015

@rultor rultor closed it by mistake, @cvrebert please take a look

@dmarkov dmarkov reopened this Jun 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Pull.head/base, which return (newly-added) PullRef
2 participants
@cvrebert @dmarkov