Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shamrock should allow to change the testing port or select the next available port #556

Closed
emmanuelbernard opened this issue Jan 17, 2019 · 2 comments
Labels
kind/bug Something isn't working
Milestone

Comments

@emmanuelbernard
Copy link
Member

Some had shamrock fail because their port were already used 8080.
Either override the port for shamrock tests or use the next available port after 8080.

Did I capture that accurately?

@emmanuelbernard emmanuelbernard added the kind/bug Something isn't working label Jan 17, 2019
@FroMage
Copy link
Member

FroMage commented Jan 17, 2019

Normally, what you do is let the server open a port on 0 which gives you a random free port, and then the tests ask the server for its port and use it in the tests: https://docs.oracle.com/javase/7/docs/api/java/net/ServerSocket.html#ServerSocket%28int%29

@Sanne
Copy link
Member

Sanne commented Jan 17, 2019

Did I capture that accurately?

Missed that I was referring to an existing bug :)

Closing as duplicate of #508

@Sanne Sanne closed this as completed Jan 17, 2019
@cescoffier cescoffier added this to the 0.7.0 milestone Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants