CSS3 Support, other optimisations #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added a css support test for border radius * added css to style notifications without images * added License comment to css * moved IE specific code into border-radius fallback * removed .gritter-top, moved to .gritter-item * removed _hoverState from JS as even IE7 handles :hover * optimised images * css is generated from sass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Used Gritter on a project and thought I might thank you by adding support for css3 (with a fallback for IE7/8). Tested in Chrome and IE7:
.no-borderradiusclass to body (same class as used by Modernizr).gritter-top, as.gritter-itemis enough (I think it was a vestige from when the images were not yet sprited):hover, as long as you have a proper doctypeAlso, I was wondering, why are you still supporting IE7?
HTH,
Armin