Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor suggestions #12

Open
wsdewitt opened this issue Oct 22, 2023 · 0 comments
Open

minor suggestions #12

wsdewitt opened this issue Oct 22, 2023 · 0 comments

Comments

@wsdewitt
Copy link
Collaborator

wsdewitt commented Oct 22, 2023 •
edited
Loading

A couple minor suggestions

  1. I noticed the tite-seq concentration sequence is hard-coded in several notebooks as conc=c(10^-6, 10^-7, 10^-8, 10^-9, 10^-10, 10^-11, 10^-12, 10^-13,0): https://github.com/search?q=repo%3Ajbloomlab%2FAb-CGGnaive_DMS+conc%3D&type=code. It might be preferable/safer to put these sequences in a config file.
  2. There are several references to "SARS-CoV-2" and "RBD", probably inherited from the RBD tite-seq repo: https://github.com/search?q=repo%3Ajbloomlab%2FAb-CGGnaive_DMS+%28rbd+OR+sars%29&type=code. Probably these should refer to the chigy Ab instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wsdewitt