feat: idp/rp test apps #1332
Merged
feat: idp/rp test apps #1332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1332 +/- ##
==========================================
+ Coverage 97.44% 97.46% +0.02%
==========================================
Files 32 32
Lines 2073 2092 +19
==========================================
+ Hits 2020 2039 +19
Misses 53 53
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dopry
force-pushed
the
feature/test-apps
branch
4 times, most recently
from
787a0e1 to
cee2181
Compare
It is possible to control CORS by overriding is_origin_allowed method of RequestValidator class. OAuthLib allows origin if: - is_origin_allowed returns True for particular request - Request connection is secure - Request has 'Origin' header
for more information, see https://pre-commit.ci
Contributor
|
I'll look into this PR on Friday. |
tonial
approved these changes
Oct 16, 2023
Contributor
There was a problem hiding this comment.
I think this test app is a great addition to this project.
I've never used svelte before so I don't really feel qualified to judge this part of this PR, but it works and it's easy to use, so I think it should be enough for anyone.
I also think the svelte part would benefit from enhancements in the future to be able to test multiple scenarios (with or without PKCE, using basic auth or passing client_id + client_secret, ...), but it should not slow down this PR.
Implement a minimal testing IDP and RP for maintainers. There is a single Application configured in the IDP for the RP sample application it used the OIDC Authorization + PKCE flow. This is a meant to be a starting point for building out further test scenarios.
dopry
force-pushed
the
feature/test-apps
branch
from
cee2181 to
50dff93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a minimal testing IDP and RP for maintainers.
There is a single Application configured in the IDP for the RP sample application it used the OIDC Authorization + PKCE flow.
This is a meant to be a starting point for building out further test scenarios.
applies to #1266
Description of the Change
implements a test IDP using DOT and RP as a pre-cursor to developing playwright E2E tests.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS