Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup of SQLite fail if there are Virtual Tables (e.g. FTS tables). #458

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

xbello
Copy link
Contributor

@xbello xbello commented Aug 15, 2022

Type of PR (feature, enhancement, bug fix, etc.)

Bug fix

Description

Backup failed if the database included Virtual Tables (e.g. tables created for FTS).

Not sure if I should ammend line 36 instead (fix to CREATE VIRTUAL TABLE IF NOT EXISTS).

Related to #457, but I can't be sure #457 was also caused by virtual tables.

Why should this be added

App is currently broken for almost any Wagtail, as long as it includes "search" and is indexed.

Checklist

  • [NOT NEEDED ] Documentation has been added or amended for this feature / update

@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #458 (73b4ff2) into master (d601574) will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
+ Coverage   90.89%   91.12%   +0.22%     
==========================================
  Files          19       19              
  Lines         857      856       -1     
  Branches      171      171              
==========================================
+ Hits          779      780       +1     
+ Misses         42       41       -1     
+ Partials       36       35       -1     
Impacted Files Coverage Δ
dbbackup/db/sqlite.py 92.72% <100.00%> (+3.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Archmonger Archmonger merged commit 3d94b0d into jazzband:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants