Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jazzband transfer tasks #418

Merged
merged 11 commits into from
Apr 27, 2022
Merged

Jazzband transfer tasks #418

merged 11 commits into from
Apr 27, 2022

Conversation

Archmonger
Copy link
Contributor

Handles jazzband transfer tasks listed in #417

@Archmonger Archmonger changed the title Master Jazzband transfer tasks Jan 7, 2022
contributing.md Show resolved Hide resolved
@Archmonger
Copy link
Contributor Author

@johnthagen I'm not sure how to integrate with jazzband's codecov. Things might still be linked to the original codecov page?

Do you have any advice here?

@Archmonger
Copy link
Contributor Author

I've added the jazzband bot to RTD. For backup purposes, I'd also like to add @johnthagen but I don't know your RTD username.

@johnthagen
Copy link
Contributor

@Archmonger My RTD username is johnthagen

@Archmonger
Copy link
Contributor Author

Alright. You've been added to RTD.

@Archmonger Archmonger requested a review from johnthagen April 27, 2022 21:10
@Archmonger
Copy link
Contributor Author

@johnthagen
I think we should merge this PR.

I don't know what else needs to be done to get codecov disconnected from the old URL and then connected to this project in Jazzband. And also not entirely sure what else needs to be customized with our project release CI.

But these can be handled on separate PRs.

@Archmonger Archmonger marked this pull request as ready for review April 27, 2022 21:13
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@2ef053c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #418   +/-   ##
=========================================
  Coverage          ?   90.87%           
=========================================
  Files             ?       19           
  Lines             ?      855           
  Branches          ?      173           
=========================================
  Hits              ?      777           
  Misses            ?       42           
  Partials          ?       36           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef053c...1901bca. Read the comment docs.

@Archmonger Archmonger merged commit 8ae735a into master Apr 27, 2022
@Archmonger Archmonger deleted the jazzband-transfer branch April 27, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants