Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-drop parameter dbrestore #400

Merged
merged 6 commits into from
Aug 23, 2024

Conversation

eberonsh
Copy link
Contributor

@eberonsh eberonsh commented Oct 20, 2021

Add a parameter to the command dbrestore. This option allows to set if the connector sends or not a clean parameter in the restore command.

Why should this be added

The restore command sends by default a --clean argument and there is no option to remove it in case it is causing a problem with the restoration process.

Adding this option allows to control sending the --clean to the restore command in case of any trouble.

@eberonsh eberonsh force-pushed the nodrop_database_option branch from a05dfb2 to 9e30344 Compare October 20, 2021 15:22
@eberonsh eberonsh force-pushed the nodrop_database_option branch from 9e30344 to 1aca3fd Compare October 20, 2021 15:30
dbbackup/management/commands/dbrestore.py Outdated Show resolved Hide resolved
dbbackup/management/commands/dbrestore.py Outdated Show resolved Hide resolved
dbbackup/management/commands/dbrestore.py Outdated Show resolved Hide resolved
@Archmonger Archmonger marked this pull request as draft April 29, 2022 07:51
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.12%. Comparing base (8f1307e) to head (f4e0e60).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
- Coverage   91.40%   91.12%   -0.29%     
==========================================
  Files          19       19              
  Lines         873      901      +28     
  Branches      157      161       +4     
==========================================
+ Hits          798      821      +23     
- Misses         40       43       +3     
- Partials       35       37       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archmonger Archmonger marked this pull request as ready for review August 23, 2024 21:34
@Archmonger Archmonger changed the title Add a parameter to configure if cleaning the database during a backup… Add no-drop parameter dbrestore Aug 23, 2024
@Archmonger Archmonger merged commit 163bd9e into jazzband:master Aug 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants