-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: performancewarning #376
Conversation
* Allow continuing a simulation * Feedback * fixups
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not merging into main
, right?
I think it's better merged to |
Thanks @huangziwei! Unfortunately the latter 2 bullet points in #375 are still triggering the performance warning for me though |
The performance warning for adding channels is fixed though! |
I guess it's device dependent (My laptop has 16Gb RAM), and there's no warning when I ran your retina notebook. It's also why I said the fix likely just delays the warning... can you try replacing
in network.py with
? |
Just do this at the beginning of your script to suppress the warning: import pandas as pd
from warnings import simplefilter
simplefilter(action="ignore", category=pd.errors.PerformanceWarning) |
I think the concern is some pandas operations used up too much RAM, so we should handle them in a more efficient way. |
are we really having problems with this or is it just the warning? I don't think that pandas is a limiting factor to runtime performance of Jaxley. |
It is not a problem, just a low-priority thing to improve. Anyone who uses groups in Jaxley would probably get severely annoyed by the warning and have to silence it though. The warning is actually gone now for me though thanks to the changes! |
I am not sure it has to do with groups, just with lots of mechanisms |
Yes I think you're right |
I am closing this as the major patches has been merged into the |
fix #375. All tests passed.
It also seems just fixing the warning from
base.py
will also fix (or delay) the warnings in other places.