Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in save_exp #344

Open
jnsbck opened this issue Apr 17, 2024 · 4 comments
Open

typo in save_exp #344

jnsbck opened this issue Apr 17, 2024 · 4 comments
Labels
good first issue Good for newcomers

Comments

@jnsbck
Copy link
Contributor

jnsbck commented Apr 17, 2024

should be safe_exp.

def save_exp(x, max_value: float = 20.0):

@huangziwei
Copy link
Contributor

how can it even happen with so many eyes! (I blame my mindlessness)

@michaeldeistler
Copy link
Contributor

ahahah oh wow yes

@jnsbck
Copy link
Contributor Author

jnsbck commented Apr 19, 2024

Could make this an easter egg and add a doc """saves the exponential""" :D

@michaeldeistler michaeldeistler added the good first issue Good for newcomers label Oct 23, 2024
@kyralianaka
Copy link
Contributor

I didn't even think this was a typo; it makes complete sense:)
Can we keep it like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants