Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we allow compartments of different length in a single branch? #127

Open
michaeldeistler opened this issue Jun 15, 2023 · 4 comments

Comments

@michaeldeistler
Copy link
Contributor

NEURON does not allow this. Also, the following might be misleading in neurax:

branch.set_params("length", 10.0)

because it might appear that the branch will have length 10.0. But in fact, every compartment in the branch will have length 10.0.

@jnsbck
Copy link
Contributor

jnsbck commented Dec 7, 2023

If its trivial to do, I would keep this as an option. What would the reasons for not doing it be ?

@michaeldeistler
Copy link
Contributor Author

To be clear: jaxley does allow compartments of different lenghts right now, even in a single branch.

The reason to remove this feature would be purely that it can be a bit misleading (as written above in the code example). But I agree that this is not a high-priority thing to change, and I am not even sure if we should enforce it.

@jnsbck
Copy link
Contributor

jnsbck commented Dec 7, 2023

One could also warn the user when they call branch.set_params("length", 10.0).

@michaeldeistler
Copy link
Contributor Author

yes definitely also possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants